Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force center after view animation. #9541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Nov 26, 2024

For https://camptocamp.atlassian.net/browse/GSSCHWYZ-429
And camptocamp/GeoMapFish#92

But will break (origin): https://camptocamp.atlassian.net/browse/GSGMF-2009
Who looks to be a issue on a particular GMF.

This workaround was making the map less blurry in case of map height with a not round number of pixels, but it cause the map zoom to "jump" if the view.contrainResolution is set to true.

My idea is to trash this function, and let the concerned GMF implement it on need.

Another possibility would be keep the function in the code but not active by default (let the user choose if he want to use it).

Or to add a options in the vars to activate it or not.

If we keep it we could also add a debounce to to not recenter too quickly.

Examples
Storybook
API help
API documentation

This workaround was making the map less blury in case of map height with a not
round number of pixels, but it cause the map zoom to "jump" if the
view.contrainResolution is set to true.
@sbrunner
Copy link
Member

This code is required to don't get bury tiles, this should be activated by default, we can add an option to be able to disable it.

@ger-benjamin
Copy link
Member Author

Ok, I've more contexte now, so all the PSC asked for this feature because at some point, OL changes has made the WMTS layers sometimes blury.
In this case, I'll try first to check if the WMTS still are blurry (maybe that's not anymore the case with latest OL).
If not, I'll keep this function activated by default, but add a possibility to disable it (via js) and I'll try to add a debounce or some new code to not have this ugly "jump" behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants